forgejo/services
Gusted b55c72828e feat(sec): Add SSH signing support for instances (#6897)
- Add support to set `gpg.format` in the Git config, via the new `[repository.signing].FORMAT` option. This is to tell Git that the instance would like to use SSH instead of OpenPGP to sign its commits. This is guarded behind a Git version check for v2.34.0 and a check that a `ssh-keygen` binary is present.
- Add support to recognize the public SSH key that is given to `[repository.signing].SIGNING_KEY` as the signing key by the instance.
- Thus this allows the instance to use SSH commit signing for commits that the instance creates (e.g. initial and squash commits) instead of using PGP.
- Technically (although I have no clue how as this is not documented) you can have a different PGP signing key for different repositories; this is not implemented for SSH signing.
- Add unit and integration testing.
  - `TestInstanceSigning` was reworked from `TestGPGGit`, now also includes testing for SHA256 repositories. Is the main integration test that actually signs commits and checks that they are marked as verified by Forgejo.
  - `TestParseCommitWithSSHSignature` is a unit test that makes sure that if a SSH instnace signing key is set, that it is used to possibly verify instance SSH signed commits.
  - `TestSyncConfigGPGFormat` is a unit test that makes sure the correct git config is set according to the signing format setting. Also checks that the guarded git version check and ssh-keygen binary presence check is done correctly.
  - `TestSSHInstanceKey` is a unit test that makes sure the parsing of a SSH signing key is done correctly.
  - `TestAPISSHSigningKey` is a integration test that makes sure the newly added API route `/api/v1/signing-key.ssh` responds correctly.

Documentation PR: forgejo/docs#1122

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6897
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: Gusted <postmaster@gusted.xyz>
Co-committed-by: Gusted <postmaster@gusted.xyz>
2025-04-11 13:25:35 +00:00
..
actions feat: move UpdateTaskByState to services 2025-04-10 08:38:28 +02:00
agit chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
asymkey feat(sec): Add SSH signing support for instances (#6897) 2025-04-11 13:25:35 +00:00
attachment Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
auth Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
automerge chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
context Git client will follow 301 but 307 (#34005) 2025-04-01 02:28:02 +02:00
contexttest Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
convert fix(migrations): transfer PR flow information (#7421) 2025-04-03 06:47:37 +00:00
cron chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
doctor feat: use XORM EngineGroup instead of single Engine connection (#7212) 2025-03-30 11:34:02 +00:00
externalaccount chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
f3 Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
federation feat(activitiypub): enable HTTP signatures on all ActivityPub endpoints (#7035) 2025-04-03 15:24:15 +00:00
feed chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
forgejo chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
forms fix(ui): display user-friendly message for range error (#7420) 2025-04-02 15:48:09 +00:00
gitdiff Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
indexer chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
issue Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
lfs Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
mailer Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
markup chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
migrations fix(migrations): transfer PR flow information (#7421) 2025-04-03 06:47:37 +00:00
mirror Fail mirroring more gracefully (#34002) 2025-04-01 02:28:02 +02:00
notify chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
org chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
packages Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
pull Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
release Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
remote chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
repository chore: refactor for Actions Done Notification (#7510) 2025-04-10 09:51:57 +00:00
secrets chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
shared/automerge chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
task chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
uinotification chore: branding import path (#7337) 2025-03-27 19:40:14 +00:00
user Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
webhook Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00
wiki Update module github.com/golangci/golangci-lint/cmd/golangci-lint to v2 (forgejo) (#7367) 2025-03-28 22:22:21 +00:00