From 8e0b86a5dc0adc61df1cc54103748f94f8d7e326 Mon Sep 17 00:00:00 2001 From: 0ko <0ko@noreply.codeberg.org> Date: Mon, 21 Apr 2025 07:25:17 +0000 Subject: [PATCH] fix(ui): overflow tabular menu CSS fixes (#7578) Change 1 Followup to https://codeberg.org/forgejo/forgejo/pulls/7314 and https://codeberg.org/forgejo/forgejo/pulls/7356 Replace baseline with center, because baseline alignment is broken with Asian scripts. Preview: https://codeberg.org/attachments/f612ca9b-5033-44f1-8bea-b71170c1f595 - bug https://codeberg.org/attachments/69e021eb-96dc-40b1-8c65-9fb4a378e051 - with fix applied Change 2 Followup to https://codeberg.org/forgejo/forgejo/pulls/7108 and https://codeberg.org/forgejo/forgejo/issues/4169 Rescope `.ui.tabular.menu .item { height: 100%;}` to overflow menu, because it was only meant for overflow menu based on PR context, but started to negatively impact the other "bookmark" style menus: they've got an extra bottom line under active tabs. Preview: https://codeberg.org/attachments/b535e437-16fd-4af2-ae8c-221618ec6b8c - bug https://codeberg.org/attachments/10a3086d-8fe7-4317-bd66-71e8139b2cc7 - bug in another area https://codeberg.org/attachments/6a6b8994-c982-48d0-98fe-68e70ba709c2 - with fix applied https://codeberg.org/attachments/8fd8a332-a9ec-4b28-948e-a4e986e301da - intended fix still applies Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7578 Reviewed-by: Michael Kriese Reviewed-by: Gusted --- web_src/css/base.css | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/web_src/css/base.css b/web_src/css/base.css index dcc33c37ff..559a035c2c 100644 --- a/web_src/css/base.css +++ b/web_src/css/base.css @@ -1054,10 +1054,11 @@ overflow-menu .overflow-menu-items { overflow-menu .overflow-menu-items .item { margin-bottom: 0 !important; /* reset fomantic's margin, because the active menu has special bottom border */ + height: 100%; } overflow-menu .overflow-menu-items .item > .svg { - align-self: baseline; + align-self: center; } overflow-menu .ui.label { @@ -1360,10 +1361,6 @@ table th[data-sortt-desc] .svg { border-color: var(--color-secondary); } -.ui.tabular.menu .item { - height: 100%; -} - .ui.tabular.menu .item, .ui.secondary.pointing.menu .item { padding: 11px 12px !important;