From 85ae9d710c44cae56adc827a0a3bf6ce4cc94bd1 Mon Sep 17 00:00:00 2001
From: Simon Ochsenreither <simon@ochsenreither.de>
Date: Fri, 28 Mar 2025 11:47:58 +0000
Subject: [PATCH] fix(ui): improve vertical alignment of icons with text in the
overflow menu (#7356)
- Follow up for #7314. Turns out this impacted the positioning of icons in tabs negatively, like the "Conversation"/"Commits"/"Files changed".
- Limit the change to the `overflow-menu` element.
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7356
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: Simon Ochsenreither <simon@ochsenreither.de>
Co-committed-by: Simon Ochsenreither <simon@ochsenreither.de>
---
web_src/css/base.css | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/web_src/css/base.css b/web_src/css/base.css
index 77458ec134..e3d2345e21 100644
--- a/web_src/css/base.css
+++ b/web_src/css/base.css
@@ -382,7 +382,6 @@ a.label,
}
.ui.menu .item > .svg {
- align-self: baseline;
margin-right: 0.35em;
}
@@ -1060,6 +1059,10 @@ overflow-menu .overflow-menu-items .item {
margin-bottom: 0 !important; /* reset fomantic's margin, because the active menu has special bottom border */
}
+overflow-menu .overflow-menu-items .item > .svg {
+ align-self: baseline;
+}
+
overflow-menu .ui.label {
margin-left: 7px !important; /* save some space */
}