From 5c1c5143618067b96eb211148897ed27d453c84c Mon Sep 17 00:00:00 2001 From: Gusted Date: Wed, 16 Apr 2025 12:28:39 +0000 Subject: [PATCH] fix(ui): make tag dropdown clickable again (#7558) - forgejo/forgejo#7187 removed the usage of `reference column` class names, however some javascript code depended on it. Adjust this code to instead use the new class `branch-tag-item`. - Ref: forgejo/forgejo#7187 ## Testing - visit a compare tag page - see it is possible search for a tag ![image](/attachments/8006fc35-96d0-49ad-94d4-078030cb2323) Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/7558 Reviewed-by: Beowulf Reviewed-by: Michael Kriese Co-authored-by: Gusted Co-committed-by: Gusted --- web_src/js/features/repo-common.js | 2 +- web_src/js/features/repo-legacy.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/web_src/js/features/repo-common.js b/web_src/js/features/repo-common.js index 038336fc0d..f4fe2f40fd 100644 --- a/web_src/js/features/repo-common.js +++ b/web_src/js/features/repo-common.js @@ -58,7 +58,7 @@ export function initRepoCloneLink() { export function initRepoCommonBranchOrTagDropdown(selector) { $(selector).each(function () { const $dropdown = $(this); - $dropdown.find('.reference.column').on('click', function () { + $dropdown.find('.branch-tag-item').on('click', function () { hideElem($dropdown.find('.scrolling.reference-list-menu')); showElem($($(this).data('target'))); return false; diff --git a/web_src/js/features/repo-legacy.js b/web_src/js/features/repo-legacy.js index 2f7db50e64..4c2ff50574 100644 --- a/web_src/js/features/repo-legacy.js +++ b/web_src/js/features/repo-legacy.js @@ -72,7 +72,7 @@ export function initRepoCommentForm() { $selectBranch.find('.ui .branch-name').text(selectedValue); } }); - $selectBranch.find('.reference.column').on('click', function () { + $selectBranch.find('.branch-tag-item').on('click', function () { hideElem($selectBranch.find('.scrolling.reference-list-menu')); $selectBranch.find('.reference .text').removeClass('black'); showElem($($(this).data('target')));